OLD Bamboo Blog - Latest Comments in Defining interfaces through mocking

Re: Defining interfaces through mocking

Anand Fox — Fri, 02 Mar 2007 03:21:00 -0000

Thanks for the great article.

I had to add the column 'owner' to the auction model to get the last test:
"context "An auction with an owner" do"
to pass. Otherwise it was failing with no such method owner= for the auction model class.

Is this necessary or is there another way to get this test to pass?

Thanks.

Re: Defining interfaces through mocking

jonathan Conway — Wed, 28 Feb 2007 07:19:00 -0000

@james/@brian - Ah I knew I forgot something:)

@eric - Easy tiger, I'll get onto different expectation vocabulary together with more advanced parts of RSpec and use of mocking in the next article.:)

Re: Defining interfaces through mocking

James H. — Tue, 27 Feb 2007 23:06:00 -0000

Unless I missed something, in step 9 your last bit of code should be:


specify "should be able to deactivate auction" do
  @auction.attributes = AuctionSpecHelper.valid_auction_attributes
  @auction.deactivate!
  @auction.activated?.should_equal false
end

Re: Defining interfaces through mocking

Eric ALlam — Tue, 27 Feb 2007 22:51:00 -0000

Mark, great introduction to Rspec and stubbing/mocking. I have recently fallen for Rspec and stubbing because, as you said, it makes our interfaces better.

One thing that caught be attention were your expectations. For instance:

@auction.valid?.should_equal false

Could be written like this:

@auction.should_not_be_valid

Rspec is clever enough (using method_missing) to run the method :valid? on the @auction object and make sure its false (because of the should_not). I find its cleaner that way and it will also take advantage of Rspec's new generated spec names feature.

Re: Defining interfaces through mocking

Mark Bennett — Tue, 27 Feb 2007 16:53:00 -0000

OK, I missed the :save stub and only saw the :new_record one.

Re: Defining interfaces through mocking

Mark Bennett — Tue, 27 Feb 2007 16:44:00 -0000

You created a mock and a stub but you didn't use any of the capabilities of mocking except for creating a stub that you didn't use.

Re: Defining interfaces through mocking

BrianC — Tue, 27 Feb 2007 15:03:00 -0000

I appreciate that you started all the way back at the 'gem install rspec'. This was a good intro for me. Thanks for taking the time to write it up. I look forward to pt 2.

One hiccup I ran into was that you never explicitly point out that we need to execute the migration. Of course, it's obvious now, but when you're focusing on shiny new things, the obvoius can go unnoticed :)

Anyway, if anyone else gets:

ActiveRecord::StatementInvalid in 'A general auction should have errors given invalid values'
ActiveRecord::StatementInvalid
./spec/models/auction_spec.rb:31:in `new'
./spec/models/auction_spec.rb:31:

just run 'rake db:migrate' and all becomes well.

Thanks again.